[webkit-reviews] review denied: [Bug 113463] [WebKit2] Need SPI to determine whether a plug-in is blocked : [Attachment 195451] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Sam Weinig <sam at webkit.org>'s
request for review:
Bug 113463: [WebKit2] Need SPI to determine whether a plug-in is blocked
https://bugs.webkit.org/show_bug.cgi?id=113463

Attachment 195451: Patch
https://bugs.webkit.org/attachment.cgi?id=195451&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195451&action=review


>> Source/WebKit2/UIProcess/API/C/WKAPICast.h:409
>> +	    case PluginModuleLoadNormally:
> 
> A case label should not be indented, but line up with its switch statement. 
[whitespace/indent] [4]

Please fix the indentation.

>> Source/WebKit2/UIProcess/API/C/WKAPICast.h:424
>> +	    case kWKPluginLoadPolicyLoadNormally:
> 
> A case label should not be indented, but line up with its switch statement. 
[whitespace/indent] [4]

Please fix the indentation.

> Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.h:56
> +WK_EXPORT WKDictionaryRef
WKContextCopyPlugInInfoForBundleIdetifier(WKContextRef context, WKStringRef
plugInBundleIdentifier);

Idetifier?

> Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.mm:89
> +WKDictionaryRef WKContextCopyPlugInInfoForBundleIdetifier(WKContextRef
contextRef, WKStringRef plugInBundleIdentifierRef)

Idetifier??

> Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.mm:103
> +    RefPtr<ImmutableDictionary> dictionary =
ImmutableDictionary::adopt(map);
> +
> +    return toAPI(dictionary.release().leakRef());

I don't think you need to the local variable here.

> Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm:174
> +PluginModuleInfo PluginInfoStore::findPluginWithBundleIdentifer(const
String& bundleIdentifer)

Identifer? How many ways are there to misspell identifier?