[webkit-reviews] review granted: [Bug 113184] Add webp image color profile support : [Attachment 195446] Patch fix const nit

[bugzilla-daemon at webkit.org]

Eric Seidel (vacation until 4/3) <eric at webkit.org> has granted noel gordon
<noel.gordon at gmail.com>'s request for review:
Bug 113184: Add webp image color profile support
https://bugs.webkit.org/show_bug.cgi?id=113184

Attachment 195446: Patch fix const nit
https://bugs.webkit.org/attachment.cgi?id=195446&action=review

------- Additional Comments from Eric Seidel (vacation until 4/3)
<eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195446&action=review


This is fine.  No worse than the rest of the code in this file.  C-memory
management is poop.

Thanks for following up.

> Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp:83
> +    if (m_transform)
> +	   qcms_transform_release(m_transform);

Ick.  I could have sworn we had a nice way to do this with RetainPtr
specializations, but I don't see it now.

> Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp:124
> +    if (m_transform)
> +	   qcms_transform_release(m_transform);
> +    m_transform = 0;

Perhaps we should have made this a releaseTransform() call at least.