[webkit-reviews] review granted: [Bug 113456] use CanvasWindingRule enumeration in CanvasRenderingContext2D.idl : [Attachment 195436] patch proposal

Wed Mar 27 18:03:25 PDT 2013

Kentaro Hara <haraken at chromium.org> has granted arno. <arno at renevier.net>'s
request for review:
Bug 113456: use CanvasWindingRule enumeration in CanvasRenderingContext2D.idl
https://bugs.webkit.org/show_bug.cgi?id=113456

Attachment 195436: patch proposal
https://bugs.webkit.org/attachment.cgi?id=195436&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195436&action=review

Thanks for improving WebKit IDLs. I think there would be more places we can use
enum (e.g. XMLHttpRequest.responseType).

> LayoutTests/fast/canvas/winding-enumeration.html:5
> +<script>

Normally we write the main script in <body>.

<head><script src="...pre.js"></script></head>
<body>
<script>main script</script>
<script src="...post.js"></script>
</body>