[webkit-reviews] review denied: [Bug 113273] Refactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormControl : [Attachment 195428] add OVERRIDE
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 27 17:21:59 PDT 2013
Kent Tamura <tkent at chromium.org> has denied Matt Falkenhagen
<falken at chromium.org>'s request for review:
Bug 113273: Refactoring: Replace Element::disabled and isEnabledFormControl
with isDisabledFormControl
https://bugs.webkit.org/show_bug.cgi?id=113273
Attachment 195428: add OVERRIDE
https://bugs.webkit.org/attachment.cgi?id=195428&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195428&action=review
> Source/WebCore/html/shadow/TextControlInnerElements.cpp:389
> RefPtr<HTMLInputElement>
input(static_cast<HTMLInputElement*>(shadowHost()));
> - if (!input || input->isDisabledOrReadOnly())
> return;
Looks very wrong.
More information about the webkit-reviews
mailing list