[webkit-reviews] review denied: [Bug 113454] GCC 4.8 error - C++ nested class inheriting enclosing class : [Attachment 195431] Patch again

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 27 16:43:04 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has denied Han Shen
<shenhan at google.com>'s request for review:
Bug 113454: GCC 4.8 error - C++ nested class inheriting enclosing class
https://bugs.webkit.org/show_bug.cgi?id=113454

Attachment 195431: Patch again
https://bugs.webkit.org/attachment.cgi?id=195431&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195431&action=review


> ChangeLog:6
> +2013-03-27  Han Shen  <shenhan at google.com>
> +
> +	   Move the definition of nested class that inherits enclosing class
outside class definition.
> +
> +	   * Source/WTF/wtf/HashMap.h: Move outside nested class definition
from enclosing class.
> +

First patch I guess :)

There is a tool to generate the changelogs. Just run
"./Tools/Scripts/prepare-ChangeLog --bug 113454"
The ChangeLogs have a certain standard format.

You will also need to include a description. Something similar to what you
explains in the bug.

> Source/WTF/wtf/HashMap.h:147
> +	       typedef typename HashMap<KeyArg, MappedArg, HashArg,
KeyTraitsArg, MappedTraitsArg>::iterator::Keys iterator;

Please privately typedef HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg,
MappedTraitsArg> to avoid the repeated args on every calls.

> Source/WTF/wtf/HashMap.h:186
> -	       typedef typename HashMap::iterator::Values iterator;
> -	       typedef typename HashMap::const_iterator::Values const_iterator;

> -	       
> +	       typedef typename HashMap<KeyArg, MappedArg, HashArg,
KeyTraitsArg, MappedTraitsArg>::iterator::Values iterator;
> +	       typedef typename HashMap<KeyArg, MappedArg, HashArg,
KeyTraitsArg, MappedTraitsArg>::const_iterator::Values const_iterator;

Ditto.


More information about the webkit-reviews mailing list