[webkit-reviews] review granted: [Bug 113360] [GTK] [gyp] Improve support for rerunning gyp automatically : [Attachment 195206] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 113360: [GTK] [gyp] Improve support for rerunning gyp automatically
https://bugs.webkit.org/show_bug.cgi?id=113360

Attachment 195206: Patch
https://bugs.webkit.org/attachment.cgi?id=195206&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195206&action=review


> Source/WebKit/gtk/gyp/GNUmakefile:16
> +	@echo "Rerunning gyp..." && ./run-gyp

&& here is unnecessary I'd say, there is no way for echo to fail, is there? ;
should do, but that's just a nit

> Source/WebKit/gtk/gyp/autogen.sh:19
> +    ln -s "$SCRIPT_DIRECTORY/GNUmakefile"

Just thinking out loud here: I'm wondering after rereading this if we shouldn't
just ln -sf, guess that can break if $SCRIPT_DIRECTORY == ., hrm