[webkit-reviews] review granted: [Bug 113448] Move preprocessing of idl to pre-pass for gyp : [Attachment 195420] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Scott Graham
<scottmg at chromium.org>'s request for review:
Bug 113448: Move preprocessing of idl to pre-pass for gyp
https://bugs.webkit.org/show_bug.cgi?id=113448

Attachment 195420: Patch
https://bugs.webkit.org/attachment.cgi?id=195420&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195420&action=review


> Source/WebCore/ChangeLog:17
> +	   * WebCore.gypi:

Nit: Please explain why you added the idl file here.

> Source/WebCore/WebCore.gyp/WebCore.gyp:649
>	 'sources': [
>	   # bison rule

Should we remove the preprocess flag from our calls to generate-bindings.pl?