[webkit-reviews] review granted: [Bug 112592] [CSS Exclusions] Add support for the simple case of padding a polygonal shape-inside : [Attachment 194902] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 112592: [CSS Exclusions] Add support for the simple case of padding a
polygonal shape-inside
https://bugs.webkit.org/show_bug.cgi?id=112592

Attachment 194902: Patch
https://bugs.webkit.org/attachment.cgi?id=194902&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194902&action=review


I need to trust you at the math. :). Some comments inside.  r=me

> Source/WebCore/rendering/ExclusionPolygon.cpp:108
> +    return inwardEdgeNormal(edge) * -1;

Maybe I wrote to much in JS lately, doesn't -inwardEdgeNormal(edge) work? :P

> Source/WebCore/rendering/ExclusionPolygon.cpp:113
> +    float startAngle = atan2(startArcVertex.y() - arcCenter.y(),
startArcVertex.x() - arcCenter.x());

No atan2f?

> Source/WebCore/rendering/ExclusionPolygon.cpp:116
> +	   startAngle += piFloat * 2;

I thought we have pi*2 in our Math header?

> Source/WebCore/rendering/ExclusionPolygon.cpp:123
> +    for (unsigned i = 1; i < arcSegmentCount; i++) {

++i