[webkit-reviews] review granted: [Bug 113442] Cache preprocessor results when generating bindings : [Attachment 195397] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Tony Chang
<tony at chromium.org>'s request for review:
Bug 113442: Cache preprocessor results when generating bindings
https://bugs.webkit.org/show_bug.cgi?id=113442

Attachment 195397: Patch
https://bugs.webkit.org/attachment.cgi?id=195397&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195397&action=review


LGTM. Thanks for fixing the issue.

> Source/WebCore/bindings/scripts/preprocessor.pm:67
> +    return @{$preprocessorCache{$fileName}} if
$preprocessorCache{$fileName};

Nit: You can write this at the beginning of the method.