[webkit-reviews] review granted: [Bug 113422] Mem mapped resource data improvements : [Attachment 195384] Patch v3 - Much better, I think!

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 113422: Mem mapped resource data improvements
https://bugs.webkit.org/show_bug.cgi?id=113422

Attachment 195384: Patch v3 - Much better, I think!
https://bugs.webkit.org/attachment.cgi?id=195384&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195384&action=review


> Source/WebKit2/NetworkProcess/mac/DiskCacheMonitor.h:30
> +#include "NetworkResourceLoader.h"

Still here?

> Source/WebKit2/NetworkProcess/mac/DiskCacheMonitor.h:47
> +    NetworkConnectionToWebProcess* connectionToWebProcess() const { return
m_connectionToWebProcess.get(); }

I don't see this used.

> Source/WebKit2/NetworkProcess/mac/DiskCacheMonitor.h:59
> +void monitorFileBackingStoreCreation(CFCachedURLResponseRef,
NetworkResourceLoader*);

Why not make this a static function in the class, to avoid friending it?

> Source/WebKit2/NetworkProcess/mac/DiskCacheMonitor.h:61
> +} // namspace WebKit

namespace, if you insist on adding a comment.

> Source/WebKit2/NetworkProcess/mac/NetworkResourceLoaderMac.mm:53
> + at interface NSCachedURLResponse (NSCachedURLResponseInternals)

We now say Details, not Internals.

> Source/WebKit2/NetworkProcess/mac/NetworkResourceLoaderMac.mm:81
> +    RetainPtr<CFURLCacheRef> cache(AdoptCF, CFURLCacheCopySharedURLCache());


I think our preferred pattern is "= adoptCF(...)" these days.

> Source/WebKit2/NetworkProcess/mac/NetworkResourceLoaderMac.mm:99
> +void NetworkResourceLoader::willCacheResponseAsync(ResourceHandle*,
NSCachedURLResponse *nsResponse)

I'd ASSERT(handle == m_handle).