[webkit-reviews] review denied: [Bug 110430] Non-painting fixed elements should not cause repaints on scroll : [Attachment 195371] Add out-of-view case

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 110430: Non-painting fixed elements should not cause repaints on scroll
https://bugs.webkit.org/show_bug.cgi?id=110430

Attachment 195371: Add out-of-view case
https://bugs.webkit.org/attachment.cgi?id=195371&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195371&action=review


Code changes look good, but the tests should be proper repaint tests.

> LayoutTests/ChangeLog:13
> +	   * compositing/repaint/scroll-fixed-layer-no-content.html: Added.
> +	   * compositing/repaint/scroll-fixed-layer-no-content-expected.png:
Added.
> +	   * compositing/repaint/scroll-fixed-layer-no-content-expected.txt:
Added.
> +	   * compositing/repaint/scroll-fixed-layer-out-of-view.html: Added.
> +	   * compositing/repaint/scroll-fixed-layer-out-of-view-expected.png:
Added.
> +	   * compositing/repaint/scroll-fixed-layer-out-of-view-expected.txt:
Added.

These tests should be text tests that dump repaint rects.