[webkit-reviews] review granted: [Bug 113383] Explicitly set editingBehavior in some tests : [Attachment 195256] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 27 11:08:06 PDT 2013
Ryosuke Niwa <rniwa at webkit.org> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 113383: Explicitly set editingBehavior in some tests
https://bugs.webkit.org/show_bug.cgi?id=113383
Attachment 195256: Patch
https://bugs.webkit.org/attachment.cgi?id=195256&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195256&action=review
> LayoutTests/ChangeLog:12
> + to use a non-Windows editingBehavior.
As far as I know, the behavior on Linux matches that of Windows.
> LayoutTests/editing/deleting/smart-delete-002.html:25
> + internals.settings.setEditingBehavior('mac');
Nit: tab character and a wrong indentation.
> LayoutTests/editing/inserting/paragraph-outside-nested-divs.html:11
> + internals.settings.setEditingBehavior("mac");
Ditto.
> LayoutTests/editing/pasteboard/drag-drop-modifies-page.html:10
> + internals.settings.setEditingBehavior("mac");
Ditto.
More information about the webkit-reviews
mailing list