[webkit-reviews] review denied: [Bug 113420] Regression(r142765) Broke Custom SVG cursors for Chromium : [Attachment 195354] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 27 11:01:50 PDT 2013


Philip Rogers <pdr at google.com> has denied Christophe Dumez <dchris at gmail.com>'s
request for review:
Bug 113420: Regression(r142765) Broke Custom SVG cursors for Chromium
https://bugs.webkit.org/show_bug.cgi?id=113420

Attachment 195354: Patch
https://bugs.webkit.org/attachment.cgi?id=195354&action=review

------- Additional Comments from Philip Rogers <pdr at google.com>
Unfortunately this isn't the best approach.

We need to re-architect how nativeImageForCurrentFrame works so that the frame
cache can be cleared when it is no longer used. With the approach in this patch
we will keep around a big chunk of memory indefinitely. One approach would be
to return a ref counted image.


More information about the webkit-reviews mailing list