[webkit-reviews] review granted: [Bug 113413] Inserting a blank (" ") at the end of a line does not insert anything in Overtype mode : [Attachment 195341] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 113413: Inserting a blank (" ") at the end of a line does not insert
anything in Overtype mode
https://bugs.webkit.org/show_bug.cgi?id=113413

Attachment 195341: Patch
https://bugs.webkit.org/attachment.cgi?id=195341&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195341&action=review


>>> Source/WebCore/editing/InsertTextCommand.cpp:106
>>> +	    
setEndingSelection(VisibleSelection(endingSelection().visibleEnd(),
endingSelection().isDirectional()));
>> 
>> Do we have a test for this?
> 
> What do you mean? For the case selectInsertedText == true ? Note that I am
not adding any code in that case, it's just a refactoring to allow us to use
setEndingSelectionWithoutValidation(). Not really required by the patch, but I
just found it convenient.

Oh, I see. Sorry, I misread your patch.