[webkit-reviews] review denied: [Bug 113260] Add a runtime flag in WebRuntimeFeatures to enable 'image/webp' accept header : [Attachment 195009] Helper method to set accept header

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 27 10:47:16 PDT 2013


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Urvang Joshi
<urvang at google.com>'s request for review:
Bug 113260: Add a runtime flag in WebRuntimeFeatures to enable 'image/webp'
accept header
https://bugs.webkit.org/show_bug.cgi?id=113260

Attachment 195009: Helper method to set accept header
https://bugs.webkit.org/attachment.cgi?id=195009&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195009&action=review


>> Source/WebCore/loader/cache/CachedImage.h:102
>> +	void setCustomAccept(); // Helper method to set the Accept header.
> 
> Would you mind renaming this to something that makes it clear that we're
setting the header? I think 'CachedImage::setCustomAcceptHeader' would be clear
enough that you could remove the comment.

+1


More information about the webkit-reviews mailing list