[webkit-reviews] review denied: [Bug 113364] Selection code spends a lot of time in InlineTextBox::localSelectionRect : [Attachment 195214] Work in progress 1

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has denied  review:
Bug 113364: Selection code spends a lot of time in
InlineTextBox::localSelectionRect
https://bugs.webkit.org/show_bug.cgi?id=113364

Attachment 195214: Work in progress 1
https://bugs.webkit.org/attachment.cgi?id=195214&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195214&action=review


Missing ChangeLog file

>> Source/WebCore/rendering/InlineTextBox.cpp:211
>> +	if (sPos != 0 || ePos != static_cast<int>(m_len))
> 
> Tests for true/false, null/non-null, and zero/non-zero should all be done
without equality comparisons.  [readability/comparison_to_zero] [5]

Please fix the style issue and add a comment.