[webkit-reviews] review granted: [Bug 110470] [GTK][AC] Animating layer disappears while running with clutter backend : [Attachment 189790] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted ChangSeok Oh
<kevin.cs.oh at gmail.com>'s request for review:
Bug 110470: [GTK][AC] Animating layer disappears while running with clutter
backend
https://bugs.webkit.org/show_bug.cgi?id=110470

Attachment 189790: Patch
https://bugs.webkit.org/attachment.cgi?id=189790&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189790&action=review


I could not reproduce this problem in webkit-clutter. I guess it might be a bad
interaction with clutter-gtk. The change makes sense anyway. Please merge this
change to webkit-clutter master as well! cq- because of the requested changes.

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:656
> +	   GraphicsLayerClutter* curChild =
static_cast<GraphicsLayerClutter*>(childLayers[i]);

Let's take the opportunity to fix the naming here, curChild -> currentChild

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:658
> +	   g_assert(GRAPHICS_LAYER_IS_ACTOR(childLayer));

Make this an ASSERT() instead.