[webkit-reviews] review granted: [Bug 113406] [Mac] Text track menu items sometimes labeled incorrectly : [Attachment 195311] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 27 09:50:11 PDT 2013
Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 113406: [Mac] Text track menu items sometimes labeled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=113406
Attachment 195311: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=195311&action=review
------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195311&action=review
r+, with nit:
> Source/WebCore/page/CaptionUserPreferencesMac.mm:541
> + if (language.isEmpty() || label.contains(language)) {
> + displayName.append(label);
> + } else {
Unnecessary braces.
More information about the webkit-reviews
mailing list