[webkit-reviews] review granted: [Bug 113363] Add a settings to disallow initializing background-size if background shorthand doesn't include it. : [Attachment 195229] change shouldResetBackgroundSizeInBackgroundShorthand to legacyBackgroundSizeShorthandBehavior to make it clearer.

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 113363: Add a settings to disallow initializing background-size if
background shorthand doesn't include it.
https://bugs.webkit.org/show_bug.cgi?id=113363

Attachment 195229: change shouldResetBackgroundSizeInBackgroundShorthand to
legacyBackgroundSizeShorthandBehavior to make it clearer.
https://bugs.webkit.org/attachment.cgi?id=195229&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195229&action=review


r=me

> Source/WebCore/css/CSSParserMode.h:77
>      bool needsSiteSpecificQuirks;
>      bool enforcesCSSMIMETypeInNoQuirksMode;
> +    bool legacyBackgroundSizeShorthandBehavior;

Nit:  There are 10 bool variables in CSSParserContext now.  Seems like we could
make them all bitfields and save some bytes on the size of the struct (as long
as they're all initialized properly).  (Not for this patch.)