[webkit-reviews] review granted: [Bug 113372] PDFPlugin: Enable PDFPlugin only if its dependencies exist on the system : [Attachment 195243] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 113372: PDFPlugin: Enable PDFPlugin only if its dependencies exist on the
system
https://bugs.webkit.org/show_bug.cgi?id=113372

Attachment 195243: patch
https://bugs.webkit.org/attachment.cgi?id=195243&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195243&action=review


>> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:42
>> +#include "PDFKitImports.h"
> 
> This needs #if PLATFORM(MAC) too.

(probably in the file itself, not around the include)

> Source/WebKit2/WebProcess/WebPage/WebPage.h:616
> +    bool pdfPluginEnabled() const;

It's not great that this function named as a simple accessor is no longer an
accessor. Can we instead perform the check on setting m_pdfPluginEnabled?