[webkit-reviews] review granted: [Bug 87140] Web Inspector: Add clear cookies context menu item to Resources > Cookies : [Attachment 195322] Plumb cookie clearing throughout the Resources Cookie tree and views - post review 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 27 07:53:45 PDT 2013


Vsevolod Vlasov <vsevik at chromium.org> has granted PhistucK
<phistuck at chromium.org>'s request for review:
Bug 87140: Web Inspector: Add clear cookies context menu item to Resources >
Cookies
https://bugs.webkit.org/show_bug.cgi?id=87140

Attachment 195322: Plumb cookie clearing throughout the Resources Cookie tree
and views - post review 4
https://bugs.webkit.org/attachment.cgi?id=195322&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195322&action=review


Thanks for fixing this!

> Source/WebCore/inspector/front-end/ResourcesPanel.js:521
> +	   this._cookieViews[cookieDomain].clear();

I would prefer if we had some CookieModel and didn't need to rely on view to
clear cookies, but it seems not that important.


More information about the webkit-reviews mailing list