[webkit-reviews] review denied: [Bug 113198] Web Inspector: provide minimized mode. : [Attachment 195251] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Dmitry Gozman
<dgozman at chromium.org>'s request for review:
Bug 113198: Web Inspector: provide minimized mode.
https://bugs.webkit.org/show_bug.cgi?id=113198

Attachment 195251: Patch
https://bugs.webkit.org/attachment.cgi?id=195251&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195251&action=review


> Source/WebCore/inspector/front-end/DockController.js:105
> +    toggleMinimize: function() {

{ should be on the next line.

> Source/WebCore/inspector/front-end/ProfilesPanel.js:381
> +    this.recordButton = new WebInspector.StatusBarButton("",
"record-profile-status-bar-item visible-in-minimized");

You should make it a property of StatusBarButton.
this.recordButton.makeVisibleWhenMinimized();

> Source/WebCore/inspector/front-end/SettingsScreen.js:780
> +	       WebInspector.dockController.restore();

You should move it into showSettingsScreen.

> Source/WebCore/inspector/front-end/Toolbar.js:392
> +    moveToMinimized: function() {

mimimize

> Source/WebCore/inspector/front-end/Toolbar.js:408
> +    moveFromMinimized: function() {

restore

> Source/WebCore/inspector/front-end/inspector.css:598
> +body.minimized #drawer-view-status-bar > :not(.visible-in-minimized) {

body.mimimized .status-bar-item:not(.visible-when-minimized)

> Source/WebCore/inspector/front-end/inspector.css:616
> +#minimize-button-right {

toolbar-minimize...