[webkit-reviews] review denied: [Bug 113375] Web Inspector: [Settings] "previouslyViewedFiles" exceeds local storage quota. : [Attachment 195257] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 27 07:32:35 PDT 2013


Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 113375: Web Inspector: [Settings] "previouslyViewedFiles" exceeds local
storage quota.
https://bugs.webkit.org/show_bug.cgi?id=113375

Attachment 195257: Patch
https://bugs.webkit.org/attachment.cgi?id=195257&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195257&action=review


> Source/WebCore/inspector/front-end/TabbedEditorContainer.js:601
> +	       if (serializedHistory.length ===
WebInspector.TabbedEditorContainer.maximalPreviouslyViewedFilesCount)

What if it already was larger than maximum?


More information about the webkit-reviews mailing list