[webkit-reviews] review denied: [Bug 112666] Web Inspector: [DataGrid] Persist column widths. : [Attachment 195268] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 112666: Web Inspector: [DataGrid] Persist column widths.
https://bugs.webkit.org/show_bug.cgi?id=112666

Attachment 195268: Patch
https://bugs.webkit.org/attachment.cgi?id=195268&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195268&action=review


> Source/WebCore/inspector/front-end/DataGrid.js:600
> +    setFamily: function(family) {

setName
Here and below: { should be on the next line

> Source/WebCore/inspector/front-end/DataGrid.js:603
> +	   this._saveColumnWeights();

Why would you load and then save?

> Source/WebCore/inspector/front-end/RequestCookiesView.js:-91
> -	   this._cookiesTable.updateWidths();

Why did this go?