[webkit-reviews] review denied: [Bug 112531] Network Panel: .swf file is always presented as loading by XHR : [Attachment 194208] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 27 07:12:38 PDT 2013


Vsevolod Vlasov <vsevik at chromium.org> has denied pdeng6 <pan.deng at intel.com>'s
request for review:
Bug 112531: Network Panel: .swf file is always presented as loading by XHR
https://bugs.webkit.org/show_bug.cgi?id=112531

Attachment 194208: Patch
https://bugs.webkit.org/attachment.cgi?id=194208&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194208&action=review


You might want to discuss this with ap@ or japhet at . This would probably require
adding new CachedResource type. I still think implementing this would be too
tricky and the value added here is negligible.

> Source/WebCore/loader/ThreadableLoaderClient.h:54
> +	   virtual bool isXMLHttpRequestClient() { return false; }

This is a layering violation.


More information about the webkit-reviews mailing list