[webkit-reviews] review denied: [Bug 113327] Web Inspector: Exception in console on attempt to filter javascript messages. : [Attachment 195127] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Dmitry Zvorygin
<zvorygin at chromium.org>'s request for review:
Bug 113327: Web Inspector: Exception in console on attempt to filter javascript
messages.
https://bugs.webkit.org/show_bug.cgi?id=113327

Attachment 195127: Patch
https://bugs.webkit.org/attachment.cgi?id=195127&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195127&action=review


> Source/WebCore/inspector/front-end/ConsoleMessage.js:779
> +	   if (!this._element) return;

return should be on the next line

> Source/WebCore/inspector/front-end/ConsoleView.js:559
> +		       } else if (sourceMessage.type ===
WebInspector.ConsoleMessage.MessageType.StartGroup || sourceMessage.type ===
WebInspector.ConsoleMessage.MessageType.StartGroupCollapsed) {

This needs a test

> Source/WebCore/inspector/front-end/ConsoleView.js:673
> +	   this._messages.push(message);

Let migrate tests back to this._messages