[webkit-reviews] review denied: [Bug 112596] Web Inspector: Auto expand retaining path until there are more than one retainer. : [Attachment 194265] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Alexei Filippov
<alph at chromium.org>'s request for review:
Bug 112596: Web Inspector: Auto expand retaining path until there are more than
one retainer.
https://bugs.webkit.org/show_bug.cgi?id=112596

Attachment 194265: Patch
https://bugs.webkit.org/attachment.cgi?id=194265&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194265&action=review


> LayoutTests/inspector/profiler/heap-snapshot-summary-retainers.html:106
> +		   setTimeout(step5.bind(null, retainersRoot), 500);

This is bound to flake. Please replace the timeout with some deterministic
condition.

> LayoutTests/inspector/profiler/heap-snapshot-summary-retainers.html:183
> +		   setTimeout(step5.bind(null, retainersRoot), 500);

Ditto.