[webkit-reviews] review granted: [Bug 107539] [ca] Tell CA to clean up unused resources if a given WebProcess won't be drawing : [Attachment 194960] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 107539: [ca] Tell CA to clean up unused resources if a given WebProcess
won't be drawing
https://bugs.webkit.org/show_bug.cgi?id=107539

Attachment 194960: patch
https://bugs.webkit.org/attachment.cgi?id=194960&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194960&action=review


> Source/WebCore/platform/mac/WebCoreSystemInterface.mm:195
> +void(*wkCABackingStoreCollectBlocking)(void);

I think we should change this name to something less mysterious.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:373
> +    if (!parameters.isInWindow) {
> +	   // Page defaults to on-screen, but setIsInWindow depends on it being
a valid indicator of actually having been put into a window.
> +	   m_page->setCanStartMedia(false);
> +	   m_page->willMoveOffscreen();
> +    }

Is this behavior change detectable at all? Will it break anything?

> Source/WebKit2/WebProcess/WebProcess.cpp:1078
> +    m_inWindowPageCount--;

I think you should assert that m_inWindowPageCount is > 0 here. Consider making
it signed for slightly less bad behavior if miscounting occurs in a release
build.