[webkit-reviews] review denied: [Bug 113041] Avoid compositing fixed-position layers if container does not scroll; may fix some layer explosion issues : [Attachment 194675] Patch for review with layout tests

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 113041: Avoid compositing fixed-position layers if container does not
scroll; may fix some layer explosion issues
https://bugs.webkit.org/show_bug.cgi?id=113041

Attachment 194675: Patch for review with layout tests
https://bugs.webkit.org/attachment.cgi?id=194675&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194675&action=review


> Source/WebCore/rendering/RenderLayerCompositor.cpp:2201
> +	   RenderObject* body = renderer->parent();
> +	   while (body) {
> +	       if (body->isBody())
> +		   break;
> +	       body = body->parent();
> +	   }

There are better ways to get to the body via the DOM. See
RenderLayerBacking::isSimpleContainerCompositingLayer() for example.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:2207
> +	       bool xWillNotScroll = body->style()->overflowX() == OHIDDEN;
> +	       bool yWillNotScroll = body->style()->overflowY() == OHIDDEN;
> +	       if (xWillNotScroll && yWillNotScroll)
> +		   return false;

Can't you just ask the frameview if it has scrollbars?