[webkit-reviews] review denied: [Bug 113043] build warning for unused function parameters in indexeddb : [Attachment 194995] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 113043: build warning for unused function parameters in indexeddb
https://bugs.webkit.org/show_bug.cgi?id=113043

Attachment 194995: Patch
https://bugs.webkit.org/attachment.cgi?id=194995&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194995&action=review


> Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp:223
> -void IDBCursorBackendImpl::prefetchReset(int usedPrefetches, int
unusedPrefetches)
> +void IDBCursorBackendImpl::prefetchReset(int usedPrefetches, int /*
unusedPrefetches */)

Nit: WebKit style is to normally leave parameters unnamed if they are unused. 
The name can be found in the header file if you want to know what the param is
for.

> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:918
> -void IDBDatabaseBackendImpl::setIndexesReady(int64_t transactionId, int64_t
objectStoreId, const Vector<int64_t>& indexIds)
> +void IDBDatabaseBackendImpl::setIndexesReady(int64_t transactionId, int64_t
/* objectStoreId */, const Vector<int64_t>& indexIds)

Remove objectStoreId

> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:729
> -int compare(const LevelDBSlice& a, const LevelDBSlice& b, bool
ignoreDuplicates, bool& ok)
> +int compare(const LevelDBSlice& a, const LevelDBSlice& b, bool /*
ignoreDuplicates */, bool& ok)

Remove ignoreDuplicates

> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:752
> -int compare<ExistsEntryKey>(const LevelDBSlice& a, const LevelDBSlice& b,
bool ignoreDuplicates, bool& ok)
> +int compare<ExistsEntryKey>(const LevelDBSlice& a, const LevelDBSlice& b,
bool /* ignoreDuplicates */, bool& ok)

Remove ignoreDuplicates

> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:775
> -int compare<ObjectStoreDataKey>(const LevelDBSlice& a, const LevelDBSlice&
b, bool ignoreDuplicates, bool& ok)
> +int compare<ObjectStoreDataKey>(const LevelDBSlice& a, const LevelDBSlice&
b, bool /* ignoreDuplicates */, bool& ok)

Remove ignoreDuplicates

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:205
> -void ExecutableWithDatabase::start(IDBFactory* idbFactory, SecurityOrigin*
securityOrigin, const String& databaseName)
> +void ExecutableWithDatabase::start(IDBFactory* idbFactory, SecurityOrigin*,
const String& databaseName)

This is a good example of WebKit style.