[webkit-reviews] review denied: [Bug 113197] Web Inspector: log message searching : [Attachment 194849] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Dmitry Zvorygin
<zvorygin at chromium.org>'s request for review:
Bug 113197: Web Inspector: log message searching
https://bugs.webkit.org/show_bug.cgi?id=113197

Attachment 194849: Patch
https://bugs.webkit.org/attachment.cgi?id=194849&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194849&action=review


> Source/WebCore/inspector/front-end/Drawer.js:198
> +	       case WebInspector.Drawer.AnimationType.Slow:

please revert this.

> Source/WebCore/inspector/front-end/SearchController.js:250
> +	       this._searchHost = WebInspector.drawer;

Why can't you get search provider right here?

> Source/WebCore/inspector/front-end/View.js:432
> +    canSearch: function() {

these methods should be extracted as a separate interface implemented by Panel
and ConsoleView