[webkit-reviews] review granted: [Bug 113030] bundle-ids need to be sanitized before using them in filesystem paths : [Attachment 195047] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 26 09:51:07 PDT 2013


Alexey Proskuryakov <ap at webkit.org> has granted Simon Cooper
<scooper at apple.com>'s request for review:
Bug 113030: bundle-ids need to be sanitized before using them in filesystem
paths
https://bugs.webkit.org/show_bug.cgi?id=113030

Attachment 195047: Patch
https://bugs.webkit.org/attachment.cgi?id=195047&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195047&action=review


You didn't formally request commit queue, but since you are not a committer yet
as far as I know, I'm assuming that you want the patch to be automatically
landed.

> Source/WebKit2/ChangeLog:12
> +	   filesystem name to look up. The “/“ character should not be
allowed
> +	   and transformed into something else, in this case a “:”

Not sure if quotation marks actually got garbled, but they certainly look
garbled now. Did you use a UTF-8 aware editor?


More information about the webkit-reviews mailing list