[webkit-reviews] review granted: [Bug 113283] Code duplication between HTTPParsers and HTTPValidation : [Attachment 195038] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 113283: Code duplication between HTTPParsers and HTTPValidation
https://bugs.webkit.org/show_bug.cgi?id=113283

Attachment 195038: Patch
https://bugs.webkit.org/attachment.cgi?id=195038&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
OK. We can consider splitting parsing and validation again if this file grows
unwieldy.

As far as naming goes, "isRFC2616Token" seems a little less descriptive to me
than "isValidHTTPToken". The reason why I like the remaining name less is that
one could wonder whether being an RFC2616 token is a built-in property of a
String, like being atomic or being static. The other name reads a little more
like a validity check that it is. But the difference is very small, and maybe
it's just me thinking so.