[webkit-reviews] review denied: [Bug 113306] Web Inspector: [Elements] Syntax-highlight the "Edit as HTML" editor : [Attachment 195081] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 113306: Web Inspector: [Elements] Syntax-highlight the "Edit as HTML"
editor
https://bugs.webkit.org/show_bug.cgi?id=113306

Attachment 195081: Patch
https://bugs.webkit.org/attachment.cgi?id=195081&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195081&action=review


> Source/WebCore/inspector/front-end/ElementsPanel.js:31
> +importScript("cm/codemirror.js");

codemirror is a part of a different module, it should be only inlined in
CodeMirrorTextEditor.

> Source/WebCore/inspector/front-end/ElementsPanel.js:49
> +    this.registerRequiredCSS("cm/cmdevtools.css");

These should be loaded lazily.