[webkit-reviews] review denied: [Bug 113042] Web Inspector: expose nodes with pointer-events=none to node search tool. : [Attachment 195092] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Dmitry Gozman
<dgozman at chromium.org>'s request for review:
Bug 113042: Web Inspector: expose nodes with pointer-events=none to node search
tool.
https://bugs.webkit.org/show_bug.cgi?id=113042

Attachment 195092: Patch
https://bugs.webkit.org/attachment.cgi?id=195092&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195092&action=review


Overall looks good, couple of nits inside. Please add someone familiar with hit
testing code in render object to review for blessing.

> Source/WebCore/page/EventHandler.cpp:1662
> +    if (m_frame->contentRenderer()) {

These two lines should be a part of inspector instrumentation.

> Source/WebCore/rendering/HitTestRequest.h:42
> +	   IgnorePointerEvents = 1 << 12

IgnorePointerEventsNone