[webkit-reviews] review granted: [Bug 107092] Sheriffbot should explain rollout failures in a human readable form. : [Attachment 195017] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Alan Cutter
<alancutter at chromium.org>'s request for review:
Bug 107092: Sheriffbot should explain rollout failures in a human readable
form.
https://bugs.webkit.org/show_bug.cgi?id=107092

Attachment 195017: Patch
https://bugs.webkit.org/attachment.cgi?id=195017&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195017&action=review


> Tools/Scripts/webkitpy/tool/bot/irc_command.py:243
> +	   # Pull out file paths after the error message.

I don't think this comment is helpful. Please remove.

> Tools/Scripts/webkitpy/tool/bot/irc_command.py:248
> +	   if files:
> +	       return "Failed to apply reverse diff for file(s): %s" % ",
".join(files)
> +	   return None

I would have used tertiary here as in: return "~" if files else None but it's
not a big deal.