[webkit-reviews] review granted: [Bug 109755] Add support for using ARM FFT in WebAudio : [Attachment 194886] Patch

[bugzilla-daemon at webkit.org]

Chris Rogers <crogers at google.com> has granted Raymond Toy <rtoy at chromium.org>'s
request for review:
Bug 109755: Add support for using ARM FFT in WebAudio
https://bugs.webkit.org/show_bug.cgi?id=109755

Attachment 194886: Patch
https://bugs.webkit.org/attachment.cgi?id=194886&action=review

------- Additional Comments from Chris Rogers <crogers at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194886&action=review


Looks ok if comments are addressed --- I'm trusting that the layout test
"convolution-mono-mono.html" has been run and passes.

> Source/WebCore/platform/audio/chromium/FFTFrameOpenMAXDLAndroid.cpp:136
> +	   for (unsigned k = 1; k < m_FFTSize / 2; ++k) {

It's better to calculate m_FFTSize / 2 outside of this loop and put in local
var.

> Source/WebCore/platform/audio/chromium/FFTFrameOpenMAXDLAndroid.cpp:154
> +	   for (unsigned k = 1; k < m_FFTSize / 2; ++k) {

It's better to calculate m_FFTSize / 2 outside of this loop and put in local
var.