[webkit-reviews] review denied: [Bug 113240] TextIterator emits LF for a br element inside an empty textarea element : [Attachment 194939] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Aurimas Liutikas
<aurimas at chromium.org>'s request for review:
Bug 113240: TextIterator emits LF for a br element inside an empty textarea
element
https://bugs.webkit.org/show_bug.cgi?id=113240

Attachment 194939: Patch
https://bugs.webkit.org/attachment.cgi?id=194939&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194939&action=review


> Source/WebCore/editing/TextIterator.cpp:757
> -    return emitsOriginalText || !(node->isInShadowTree() &&
node->shadowHost()->toInputElement());
> +    return emitsOriginalText || !(node->isInShadowTree() &&
(node->shadowHost()->toInputElement() ||
isHTMLTextAreaElement(node->shadowHost())));

How does this work? This code change will make it so that we never emit new
lines for BRs inside textarea.
We need to emit BRs between lines.