[webkit-reviews] review requested: [Bug 92868] [css3-text] Add platform support for "wavy" text decoration style : [Attachment 194941] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 25 16:23:27 PDT 2013


Lamarque V. Souza <Lamarque.Souza at basyskom.com> has asked  for review:
Bug 92868: [css3-text] Add platform support for "wavy" text decoration style
https://bugs.webkit.org/show_bug.cgi?id=92868

Attachment 194941: Patch
https://bugs.webkit.org/attachment.cgi?id=194941&action=review

------- Additional Comments from Lamarque V. Souza
<Lamarque.Souza at basyskom.com>
Fix the too short curve problem. I did a benchmark and this fix adds about 4%
overhead, which translated to microseconds is less than the standard deviation
I calculated. I think that is reasonable. One problem with this fix is that two
wavy decorations in the same page but in different text strings can have
slightly different shapes. I think most people cannot notice that without
zooming in the page.


More information about the webkit-reviews mailing list