[webkit-reviews] review granted: [Bug 113231] Cleanup plugin snapshotting autostart decision making : [Attachment 194922] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 113231: Cleanup plugin snapshotting autostart decision making
https://bugs.webkit.org/show_bug.cgi?id=113231

Attachment 194922: Patch
https://bugs.webkit.org/attachment.cgi?id=194922&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194922&action=review


> Source/WebCore/html/HTMLPlugInImageElement.cpp:415
> +		   String otherMimeType = plugInImageElement->serviceType();

Other?

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:586
> -	   if (m_pluginElement->displayState() < HTMLPlugInElement::Playing)
> +	   if (m_pluginElement->displayState() ==
HTMLPlugInElement::RestartingWithPendingMouseClick)
>	       m_pluginElement->dispatchPendingMouseClick();

Whoops.

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1653
> +    // FIXME: webkit.org/b/113232 - Extend autostart timeout when this
codepath is hit.

I'm not sure how we usually format these, but I'm not sure this is it.