[webkit-reviews] review granted: [Bug 109820] TextTrack Extension for WebVTT Regions : [Attachment 194925] Proper guard

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Victor Carbune
<vcarbune at chromium.org>'s request for review:
Bug 109820: TextTrack Extension for WebVTT Regions
https://bugs.webkit.org/show_bug.cgi?id=109820

Attachment 194925: Proper guard
https://bugs.webkit.org/attachment.cgi?id=194925&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194925&action=review


> Source/WebCore/html/track/TextTrackRegion.cpp:195
> +    ExceptionCode ec = 0;
> +    setScroll(region->scroll(), ec);
> +
> +    ASSERT(!ec);

Why not use ASSERT_NO_EXCEPTION?

> LayoutTests/media/track/regions-webvtt/text-track-region-list.html:88
> +	       setTimeout(startTest, 500);

Nit: I think 500ms is much longer than it needs to be,and it guarantees that
the test takes .5 seconds. I would guess that 100ms would be sufficient.