[webkit-reviews] review granted: [Bug 11200] Image alt text not included in plain-text version when copying : [Attachment 194917] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 11200: Image alt text not included in plain-text version when copying
https://bugs.webkit.org/show_bug.cgi?id=11200

Attachment 194917: Patch
https://bugs.webkit.org/attachment.cgi?id=194917&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194917&action=review


> LayoutTests/editing/pasteboard/copy-image-with-alt-text-expected.txt:1
> +This tests that image alt text makes it to the clipboard. This test requires
DRT or WTR. The first two dumps should not include alt text and the third and
forth dumps should include alt text.

We should be able to manually test it by copying the whole thing, right?

> LayoutTests/editing/pasteboard/copy-image-with-alt-text.html:35
> +    if (window.internals)
> +	   internals.settings.setSelectionIncludesAltImageText(true);

Presumably, this setting is reset in the test runner automatically?