[webkit-reviews] review granted: [Bug 113216] [GTK] [gyp] Build the final piece of WebCore : [Attachment 194874] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 25 12:55:40 PDT 2013


Nico Weber <thakis at chromium.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 113216: [GTK] [gyp] Build the final piece of WebCore
https://bugs.webkit.org/show_bug.cgi?id=113216

Attachment 194874: Patch
https://bugs.webkit.org/attachment.cgi?id=194874&action=review

------- Additional Comments from Nico Weber <thakis at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194874&action=review


> Source/WebCore/WebCore.gyp/WebCoreGTK.gyp:904
> +	   ['exclude', 'plugins/PluginPackageNone\\.cpp$'],

fyi: You can also have a 'sources!' section, which is a list of files to
exclude, for things that don't need to be regex matches.


More information about the webkit-reviews mailing list