[webkit-reviews] review denied: [Bug 107027] [Chromium] Hide the location bar on WebKit scrolls. : [Attachment 194847] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 107027: [Chromium] Hide the location bar on WebKit scrolls.
https://bugs.webkit.org/show_bug.cgi?id=107027

Attachment 194847: Patch
https://bugs.webkit.org/attachment.cgi?id=194847&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194847&action=review


> Source/WebKit/chromium/tests/HideTopControlsTest.cpp:128
> +    frameImpl->executeScript(WebScriptSource("window.scrollBy(0, 0);"));
> +    EXPECT_TRUE(client.didHideTopControls());

This seems like the opposite of the behavior we're trying to implement.  No-op
scrolls should be no-ops.