[webkit-reviews] review granted: [Bug 113228] Don't use video to trigger compositing for layout tests : [Attachment 194896] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 25 11:59:20 PDT 2013


Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 113228: Don't use video to trigger compositing for layout tests
https://bugs.webkit.org/show_bug.cgi?id=113228

Attachment 194896: Patch
https://bugs.webkit.org/attachment.cgi?id=194896&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194896&action=review


R=me.  This looks great to me.	Video has always been the cause of a lot of
flaky layout tests.

>
LayoutTests/compositing/geometry/limit-layer-bounds-opacity-transition.html:15
> +	 width: 1px;

It might be worth making this the size of the old video, in the same way that
you resize compositing divs elsewhere to avoid expectation churn.


More information about the webkit-reviews mailing list