[webkit-reviews] review denied: [Bug 113175] Web Inspector: Remove console warnings for *_ prefixed CSS styles : [Attachment 194858] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 25 08:25:11 PDT 2013


Pavel Feldman <pfeldman at chromium.org> has denied Sergey Ryazanov
<serya at chromium.org>'s request for review:
Bug 113175: Web Inspector: Remove console warnings for *_ prefixed CSS styles
https://bugs.webkit.org/show_bug.cgi?id=113175

Attachment 194858: Patch
https://bugs.webkit.org/attachment.cgi?id=194858&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194858&action=review


> Source/WebCore/inspector/InspectorConsoleAgent.cpp:194
> +	   if (index >= 0 && static_cast<int>(message.length()) > index + 1 &&
message[index + 2] == '*')

Even when message.length() > index + 1, it does not mean message[index + 2] is
within range. Isn't it all just find(": *")?


More information about the webkit-reviews mailing list