[webkit-reviews] review denied: [Bug 113175] Web Inspector: Remove console warnings for *_ prefixed CSS styles : [Attachment 194841] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 25 06:59:08 PDT 2013
Pavel Feldman <pfeldman at chromium.org> has denied Sergey Ryazanov
<serya at chromium.org>'s request for review:
Bug 113175: Web Inspector: Remove console warnings for *_ prefixed CSS styles
https://bugs.webkit.org/show_bug.cgi?id=113175
Attachment 194841: Patch
https://bugs.webkit.org/attachment.cgi?id=194841&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194841&action=review
> Source/WebCore/css/CSSParser.cpp:11289
> + appendToken(&builder, location.token);
You don't need appendToken any longer, do you?
> Source/WebCore/css/CSSParser.h:80
> + InvalidPropertyDeclaration,
PropertyDeclarationError
> Source/WebCore/inspector/InspectorConsoleAgent.cpp:192
> + if (source == CSSMessageSource && message == "Invalid CSS property
declaration at: *")
You should only look for "*" as I suggested.
More information about the webkit-reviews
mailing list