[webkit-reviews] review denied: [Bug 113175] Web Inspector: Remove console warnings for *_ prefixed CSS styles : [Attachment 194834] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Sergey Ryazanov
<serya at chromium.org>'s request for review:
Bug 113175: Web Inspector: Remove console warnings for *_ prefixed CSS styles
https://bugs.webkit.org/show_bug.cgi?id=113175

Attachment 194834: Patch
https://bugs.webkit.org/attachment.cgi?id=194834&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194834&action=review


> Source/WebCore/css/CSSParser.cpp:11273
> +static void AppendToken(StringBuilder* builder, const CSSParserString&
token)

Methods start with lower case in WebKit.

> Source/WebCore/css/CSSParser.cpp:11294
> +    builder.appendLiteral("Invalid CSS property declaration at: ");

I'd pass enum into single syntaxError and would choose title based on the enum
value.

> Source/WebCore/inspector/InspectorConsoleAgent.cpp:191
> +    if (source == CSSMessageSource && message == "Invalid CSS property
declaration at: *")

I'd simply look for "*", please also add a comment explaining why this happens.