[webkit-reviews] review requested: [Bug 113047] Web Inspector: Fonts refactoring : [Attachment 194520] Patch

[bugzilla-daemon at webkit.org]

Alexei Filippov <alph at chromium.org> has asked  for review:
Bug 113047: Web Inspector: Fonts refactoring
https://bugs.webkit.org/show_bug.cgi?id=113047

Attachment 194520: Patch
https://bugs.webkit.org/attachment.cgi?id=194520&action=review

------- Additional Comments from Alexei Filippov <alph at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194520&action=review


>> Source/WebCore/inspector/front-end/dataGrid.css:104
>> +	padding: 1px 4px;
> 
> Did you test alignment on Mac and Windows/Linux?

Yes.

>> Source/WebCore/inspector/front-end/networkLogView.css:16
>> +	-webkit-background-size: 1px 38px;
> 
> Sounds like a significant change. Why?

I decided to make it more compact... but you're right it's unrelated to this
patch. Reverted.

>> Source/WebKit/chromium/src/js/devTools.css:15
>> +body.platform-linux {
> 
> You remove font size settings from all platforms, but only add default values
for Chromium.

I don't. There is:
body {
  font-family: Lucida Grande, sans-serif;
  font-size: 11px;
}
in inspectorCommon.css