[webkit-reviews] review denied: [Bug 109579] [CoordGfx] Speed up web process rendering with double buffering : [Attachment 194567] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 109579: [CoordGfx] Speed up web process rendering with double buffering
https://bugs.webkit.org/show_bug.cgi?id=109579

Attachment 194567: Patch
https://bugs.webkit.org/attachment.cgi?id=194567&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194567&action=review


I dont like the changes from vector of pairs to HashMap. In general I don't
think we should change CoreIPC to deal with hashsets/maps, those don't make
sense as serialized values in this context, and it's generally an orthogonal
issue to what you're trying to solve.
I think it would be good to clean this up a bit where we can see the actual
double buffering change and not all the little peripheral changes this
introduces...

>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cp
p:942
> +    if (!addResult.isNewEntry) {
> +	   // Remove old updates if imcompatible with or covered by the new
one.

Early return